Skip to content

Adding Schema Regsistry attributes for kafka trigger and ouput#1850

Merged
liliankasem merged 4 commits intomainfrom
jainh/kafkaAttributesChange
Oct 18, 2023
Merged

Adding Schema Regsistry attributes for kafka trigger and ouput#1850
liliankasem merged 4 commits intomainfrom
jainh/kafkaAttributesChange

Conversation

@jainharsh98
Copy link
Copy Markdown
Contributor

@jainharsh98 jainharsh98 commented Aug 22, 2023 •
edited
Loading

Kafka extension 3.9.0 has introduced additional attributes for Avro Schema Registry Support. This PR aims at exposing the attributes for out of proc model.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@jainharsh98 jainharsh98 marked this pull request as ready for review August 22, 2023 06:00
@liliankasem
Copy link
Copy Markdown
Member

liliankasem commented Aug 22, 2023

@jainharsh98 please also update the release notes; the "Pull request checklist" in the PR description needs to be filled in.

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service Bot commented Sep 7, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@jainharsh98 jainharsh98 reopened this Sep 21, 2023
@jainharsh98
Copy link
Copy Markdown
Contributor Author

jainharsh98 commented Sep 21, 2023

@liliankasem Updated the release_notes.md file. Please review.

liliankasem
liliankasem reviewed Sep 21, 2023
View reviewed changes
Comment thread extensions/Worker.Extensions.Kafka/release_notes.md Outdated
@surgupta-msft
Copy link
Copy Markdown
Contributor

surgupta-msft commented Oct 4, 2023

Is it possible to add some tests covering support for Avro Schema Registry? We have extensions tests - here and Kafka samples - here for reference.

@jainharsh98
Copy link
Copy Markdown
Contributor Author

jainharsh98 commented Oct 10, 2023

@surgupta-msft Kafka extension has language-based test cases in the extension repo itself. Since this repo does not have any test cases for kafka can we take it in a separate PR?

@surgupta-msft
Copy link
Copy Markdown
Contributor

surgupta-msft commented Oct 10, 2023

@surgupta-msft Kafka extension has language-based test cases in the extension repo itself. Since this repo does not have any test cases for kafka can we take it in a separate PR?

Any thoughts about adding some samples? Also, can you share link to the tests in extension repo you mentioned above?

@surgupta-msft
Copy link
Copy Markdown
Contributor

surgupta-msft commented Oct 12, 2023 •
edited
Loading

I think we also need to update the version to 3.10.0 in Worker.Extensions.Kafka.csproj. Would check with @liliankasem to confirm this. Rest all looks good to me!

@liliankasem
Copy link
Copy Markdown
Member

liliankasem commented Oct 16, 2023

I think we also need to update the version to 3.10.0 in Worker.Extensions.Kafka.csproj. Would check with @liliankasem to confirm this. Rest all looks good to me!

We can update this if we want to release this now

@liliankasem
Copy link
Copy Markdown
Member

liliankasem commented Oct 16, 2023

@jainharsh98 please add tests and samples in a new PR

@liliankasem liliankasem merged commit 254da2e into main Oct 18, 2023
@liliankasem liliankasem deleted the jainh/kafkaAttributesChange branch October 18, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liliankasem liliankasem liliankasem approved these changes

+1 more reviewer

@surgupta-msft surgupta-msft surgupta-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jainharsh98 @liliankasem @surgupta-msft